[wesnoth-commits] [wesnoth/wesnoth] 4f7e78: NR S10 - 14: minor cosmetic map tweaks

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4f7e789f2d78d38def8e10594060847c0eeb1af9
      https://github.com/wesnoth/wesnoth/commit/4f7e789f2d78d38def8e10594060847c0eeb1af9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-03 (Sun, 03 Jun 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/maps/10a_Stolen_Gold.map
    M data/campaigns/Northern_Rebirth/maps/11a_The_Eastern_Flank.map
    M data/campaigns/Northern_Rebirth/maps/12a_Get_the_Gold.map
    M data/campaigns/Northern_Rebirth/maps/13a_Showdown.map
    M data/campaigns/Northern_Rebirth/maps/14a_Epilogue.map

  Log Message:
  -----------
  NR S10 - 14: minor cosmetic map tweaks

[ci skip]


  Commit: 47618948444cf04d8a61a465216e4b0cb72f37ea
      https://github.com/wesnoth/wesnoth/commit/47618948444cf04d8a61a465216e4b0cb72f37ea
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-03 (Sun, 03 Jun 2018)

  Changed paths:
    M data/gui/window/campaign_dialog.cfg

  Log Message:
  -----------
  Campaign Dialog: renamed Deterministic Mode label to "Save random seed"

[ci skip]

This better conveys its behavior, especially with the introduction of the hidden PRNG
preference.


  Commit: 7576298464831410f3c283b06470754cf7666258
      https://github.com/wesnoth/wesnoth/commit/7576298464831410f3c283b06470754cf7666258
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-03 (Sun, 03 Jun 2018)

  Changed paths:
    M src/image.cpp

  Log Message:
  -----------
  Revert "Fixed an occasional crash resulting from multi-thread access of the image cache"

This reverts commit 0eb27e246bfc842655ee5ee4d3e1ddc326e87ebb. Turns out there's
a better way to fix this problem without using mutexes, which have a noticeable
performance hit (5.2% of the execution time of game_display::draw_invalidated()
according to @jyrkive).


  Commit: 287775c7879e74be2e4a02df6f744649034caef2
      https://github.com/wesnoth/wesnoth/commit/287775c7879e74be2e4a02df6f744649034caef2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-03 (Sun, 03 Jun 2018)

  Changed paths:
    M src/game_config_manager.cpp

  Log Message:
  -----------
  Game Config Manager: handle clearing image cache in main thread

See comment for explanation. This was a better solution that adding mutexes to
the cache accessors; that had performance downsides.


Compare: https://github.com/wesnoth/wesnoth/compare/e9639b58a4be...287775c7879e
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.