[wesnoth-commits] [wesnoth/wesnoth] 5ece2c: Don't assume unit is on the map when testing abili...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5ece2cc0892f835c7589366f85627cf0de762b08
      https://github.com/wesnoth/wesnoth/commit/5ece2cc0892f835c7589366f85627cf0de762b08
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  Don't assume unit is on the map when testing ability active

This refactors ability tests to use a passed-in unit instead of
searching for the unit on the map based on its location.

While it does fix #2247, I am not confident that this won't also
have some undesirable side-effects.


  Commit: c3f64e59f063305fec0b92049433148c4a7d86fd
      https://github.com/wesnoth/wesnoth/commit/c3f64e59f063305fec0b92049433148c4a7d86fd
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  Use RAII for weapon specials context to ensure no dangling pointers


  Commit: 2f7704dab9a1a249cb9194a5fbc533267299fe4a
      https://github.com/wesnoth/wesnoth/commit/2f7704dab9a1a249cb9194a5fbc533267299fe4a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Fix an obvious-looking error in attack action


  Commit: b02e6749d050b3e6f106c317a12bf7fb403b05e3
      https://github.com/wesnoth/wesnoth/commit/b02e6749d050b3e6f106c317a12bf7fb403b05e3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/units/abilities.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  Address edge-case where copy elision doesn't occur


  Commit: 579bbc464ff0e6f31c9c8d219878b256710d088a
      https://github.com/wesnoth/wesnoth/commit/579bbc464ff0e6f31c9c8d219878b256710d088a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Ensure a weapon specials context is active when attack events are fired


Compare: https://github.com/wesnoth/wesnoth/compare/900a159c8bca...579bbc464ff0