[wesnoth-commits] [wesnoth/wesnoth] 900a15: Attempt to fix suspected race condition when runni...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 900a159c8bca57eb6c0efe903e6be1609ff46973
      https://github.com/wesnoth/wesnoth/commit/900a159c8bca57eb6c0efe903e6be1609ff46973
  Author: pentarctagon <pentarctagon at tutamail.com>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M utils/travis/mp_test_executor.sh
    M utils/travis/steps/script.sh

  Log Message:
  -----------
  Attempt to fix suspected race condition when running MP tests.

Currently the MP unit tests will randomly fail due to one of the two background wesnoth instances failing video initialization.  All unit tests require the display server to be initialized however, or they fail with the same error as the MP tests sometimes fail with.  However, the MP tests are the only tests to randomly fail due to video initialization, while for the same travis job the WML unit tests (which run before) and the boost unit tests (which run after) are still able to be successfully completed.

Therefore, the video initialization failures are not entirely random, and the MP tests are also the only tests that experience this failure while also being the only tests that have more than one instance of wesnoth running simultaneously.

tl;dr: the attempted solution here is to sleep for 5 seconds between starting background processes in the mp unit test script.

Also removes starting the display server prior outside of the docker container, since that's not needed anymore.