[wesnoth-commits] [wesnoth/wesnoth] e9105a: help: Fix ToD Schedule topic index heading not bei...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e9105ab8a708b729d10057ba3a9acaacc53e1d64
      https://github.com/wesnoth/wesnoth/commit/e9105ab8a708b729d10057ba3a9acaacc53e1d64
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-03-31 (Sat, 31 Mar 2018)

  Changed paths:
    M changelog.md
    M src/help/help_impl.cpp

  Log Message:
  -----------
  help: Fix ToD Schedule topic index heading not being translatable

Again, someone forgot to make this translatable. Fortunately, for 1.14
we can rely on a very simple hack to borrow the same string from the
wesnoth-help textdomain, which is actually supposed to be used for the
same purpose as it is the top-level section's title there, which is also
supposed to be the heading for the section's index.

This kind of thing just goes to show how badly organized the whole help
system is code-wise.


  Commit: 161d17bdb2453c5e4b2eea2ee5fc5c996706008f
      https://github.com/wesnoth/wesnoth/commit/161d17bdb2453c5e4b2eea2ee5fc5c996706008f
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-03-31 (Sat, 31 Mar 2018)

  Changed paths:
    M changelog.md
    M src/help/help_impl.cpp

  Log Message:
  -----------
  help: Borrow "Lawful Bonus" translation from wesnoth-lib

Again, no-one marked this one as translatable.


  Commit: 82af89f950fc90c3326a85cad6f5485a85d5d8b2
      https://github.com/wesnoth/wesnoth/commit/82af89f950fc90c3326a85cad6f5485a85d5d8b2
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-03-31 (Sat, 31 Mar 2018)

  Changed paths:
    M changelog.md
    M src/help/help_impl.cpp

  Log Message:
  -----------
  help: Call gettext on ToD topic strings that are already marked translatable

I'm getting the feeling whoever wrote this didn't really know what N_()
does or doesn't do.


Compare: https://github.com/wesnoth/wesnoth/compare/4cd98821a936...82af89f950fc