[wesnoth-commits] [wesnoth/wesnoth] 64273a: add a comment

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 64273a4c3bfc882143cb79d09c56bec48c27b5e9
      https://github.com/wesnoth/wesnoth/commit/64273a4c3bfc882143cb79d09c56bec48c27b5e9
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-05 (Sat, 05 May 2018)

  Changed paths:
    M src/whiteboard/side_actions.cpp

  Log Message:
  -----------
  add a comment


  Commit: 1a135b7e00471856854386557a9763245b327ae9
      https://github.com/wesnoth/wesnoth/commit/1a135b7e00471856854386557a9763245b327ae9
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-05 (Sat, 05 May 2018)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  wb: prevent unit id conflics

the wb recruit actions store temp units with fake ids and live longer
than a turn, so resetting the underlying id counter between turns might
result in dublicate id errors in wb recruit actions ( #1517 ), which
might lead to errors later.

With this it is of course possible to get erros when more than 2^31 (or
2^63 on a 64 bit wesnoth version.) fake units are generated during a
game, but that is less likely.


Compare: https://github.com/wesnoth/wesnoth/compare/54e5c54c796c...1a135b7e0047
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.