[wesnoth-commits] [wesnoth/wesnoth] 5c278a: editor: don't allow bad location id strings

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5c278a39364ed1a7d04892f6c33ede3d64961cc8
      https://github.com/wesnoth/wesnoth/commit/5c278a39364ed1a7d04892f6c33ede3d64961cc8
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M src/editor/palette/location_palette.cpp

  Log Message:
  -----------
  editor: don't allow bad location id strings 

in particular using spaces or commas here results in invalid map files when the map is written to disk. (repoted on the forum)


  Commit: 5884aa27ea9d5a18203e2618c1c0a55321f5dc9e
      https://github.com/wesnoth/wesnoth/commit/5884aa27ea9d5a18203e2618c1c0a55321f5dc9e
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M src/whiteboard/side_actions.cpp

  Log Message:
  -----------
  wb: don't clear undo stack when dsu is active

since that might lead to assertion failures&oos later, fixes #3029


  Commit: 6a9e2c260d8dd6a3a476f91768547ec7e2afff71
      https://github.com/wesnoth/wesnoth/commit/6a9e2c260d8dd6a3a476f91768547ec7e2afff71
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M src/whiteboard/recruit.cpp

  Log Message:
  -----------
  wb: add a assertion


  Commit: eaabf1648d9d200c2f44b7170efcba67bc724061
      https://github.com/wesnoth/wesnoth/commit/eaabf1648d9d200c2f44b7170efcba67bc724061
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M src/whiteboard/manager.cpp
    M src/whiteboard/move.cpp

  Log Message:
  -----------
  wb: fix incorrect handling of skirmisher.

fixes #3014


  Commit: fd48bad8d929a5ec48d0eeeae063a07b046ea1b4
      https://github.com/wesnoth/wesnoth/commit/fd48bad8d929a5ec48d0eeeae063a07b046ea1b4
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M src/fake_unit_ptr.cpp

  Log Message:
  -----------
  wb: fix segfault when ending the game

fixes #3008

This is not the prettiest fix, but in particular for 1.14 stable it's
less risky than some big refactor.


Compare: https://github.com/wesnoth/wesnoth/compare/0d15c1e19e65...fd48bad8d929
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.