[wesnoth-commits] [wesnoth/wesnoth] ee5017: fix different carryover when loading startofscenar...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ee50171d13c7f20a3c8147201c2b78ab54fafae3
      https://github.com/wesnoth/wesnoth/commit/ee50171d13c7f20a3c8147201c2b78ab54fafae3
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M src/carryover.cpp
    M src/game_initialization/connect_engine.cpp

  Log Message:
  -----------
  fix different carryover when loading startofscenario-save

this removes a hack in connect_engine.cpp that set save_id to a value to make sure that other connect_engine.cpp code does not chnge it later to the plyers id, (it did so at some point iirc).

Instead we update carryover.cpp to make sure that a side with no save_id  (or id since save_id defaults to id) is not carried over to the next scenario,

fixes #3152



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.