[wesnoth-commits] [wesnoth/wesnoth] 5395fc: Moved faction sorting from the FLG manager to the ...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5395fcd106176abdbf1c44a1fcd9024c5ed3173a
      https://github.com/wesnoth/wesnoth/commit/5395fcd106176abdbf1c44a1fcd9024c5ed3173a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-27 (Sun, 27 May 2018)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/flg_manager.cpp

  Log Message:
  -----------
  Moved faction sorting from the FLG manager to the connect engine

This list in the connect engine was passed to each of its side engine's flg managers,
where it was then sorted by update_choosable_factions(). Basically, a whole bunch of
unnecessary sorting. This makes it so the list is already sorted when it's passed to
each side engine.

None of the post-processing of the faction list (in populating available_leaders_)
should mess with the order, as far as I can tell.


  Commit: b56dcb38c297eea6fb1e195397b2e7b61752c99d
      https://github.com/wesnoth/wesnoth/commit/b56dcb38c297eea6fb1e195397b2e7b61752c99d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-27 (Sun, 27 May 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_staging.cpp

  Log Message:
  -----------
  MP Staging: simplify a call


Compare: https://github.com/wesnoth/wesnoth/compare/67d2ee7db083...b56dcb38c297
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.