[wesnoth-commits] [wesnoth/wesnoth] 050430: Moved faction sorting from the FLG manager to the ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 050430460adb5dc1ed3968a737e3be46dc216bf5
      https://github.com/wesnoth/wesnoth/commit/050430460adb5dc1ed3968a737e3be46dc216bf5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-27 (Sun, 27 May 2018)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/flg_manager.cpp

  Log Message:
  -----------
  Moved faction sorting from the FLG manager to the connect engine

This list in the connect engine was passed to each of its side engine's flg managers,
where it was then sorted by update_choosable_factions(). Basically, a whole bunch of
unnecessary sorting. This makes it so the list is already sorted when it's passed to
each side engine.

None of the post-processing of the faction list (in populating available_leaders_)
should mess with the order, as far as I can tell.


  Commit: 99c2ed8f65da39ef24dfd339eb12486275009eec
      https://github.com/wesnoth/wesnoth/commit/99c2ed8f65da39ef24dfd339eb12486275009eec
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-27 (Sun, 27 May 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_staging.cpp

  Log Message:
  -----------
  MP Staging: simplify a call


Compare: https://github.com/wesnoth/wesnoth/compare/0c3ca19e9d36...99c2ed8f65da
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.