[wesnoth-commits] [wesnoth/wesnoth] 4d8862: New helper function

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4d8862b46ca33d207d4a3b75a880b69bbcb88ea7
      https://github.com/wesnoth/wesnoth/commit/4d8862b46ca33d207d4a3b75a880b69bbcb88ea7
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  New helper function


  Commit: 81b3c3f226f7704eb8e0d8a6929298f20bbe389e
      https://github.com/wesnoth/wesnoth/commit/81b3c3f226f7704eb8e0d8a6929298f20bbe389e
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/attack.hpp

  Log Message:
  -----------
  Add a new overload to combat_modifier


  Commit: 00f5b8822af03b31c5c4a1fa2a5cb06076217aac
      https://github.com/wesnoth/wesnoth/commit/00f5b8822af03b31c5c4a1fa2a5cb06076217aac
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/game_display.hpp

  Log Message:
  -----------
  Expose attack_indicator_src_


  Commit: 27c9086be77ac95c74d4243c968d7d4b54280909
      https://github.com/wesnoth/wesnoth/commit/27c9086be77ac95c74d4243c968d7d4b54280909
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Show the alignment the selected unit will have at the mouseover hex, not at its current location, to match the time_of_day and tod_stats reports


  Commit: a03740923f1d8207cb7aeba856590383ca5e783d
      https://github.com/wesnoth/wesnoth/commit/a03740923f1d8207cb7aeba856590383ca5e783d
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Have unit_weapons use the alignment at the mouseover hex, for consistency with the alignment and tod reports


  Commit: 55e3fa36605824e64be4a09e4e4f1bac38bc909f
      https://github.com/wesnoth/wesnoth/commit/55e3fa36605824e64be4a09e4e4f1bac38bc909f
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/attack.hpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp

  Log Message:
  -----------
  Simplify under_leadership().

It now takes a unit pointer directly instead of searching for it by
location, even though callers already had the unit pointer.

This also improves the sidebar weapons report. Now, if the mouseover hex
is adjacent both to an allied leader and to an enemy, the sidebar will
reflect the leadership bonus.


  Commit: 839c9f37c7ef4aec77c015d19246f9cbf271ca7f
      https://github.com/wesnoth/wesnoth/commit/839c9f37c7ef4aec77c015d19246f9cbf271ca7f
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Rename formal parameter


  Commit: d59dd8fb5ca600c58d6fc99647d8ae463af12b4a
      https://github.com/wesnoth/wesnoth/commit/d59dd8fb5ca600c58d6fc99647d8ae463af12b4a
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Simplify under_leadership() further.

Avoid an expensive clone().


  Commit: 80069fa9dd00d38aca626a2c552f962f1f98dc32
      https://github.com/wesnoth/wesnoth/commit/80069fa9dd00d38aca626a2c552f962f1f98dc32
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/attack.hpp
    M src/game_display.hpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'josteph/report-alignment'

* josteph/report-alignment:
  Simplify under_leadership() further.
  Rename formal parameter
  Simplify under_leadership().
  Have unit_weapons use the alignment at the mouseover hex, for consistency with the alignment and tod reports
  Show the alignment the selected unit will have at the mouseover hex, not at its current location, to match the time_of_day and tod_stats reports
  Expose attack_indicator_src_
  Add a new overload to combat_modifier
  New helper function


Compare: https://github.com/wesnoth/wesnoth/compare/5f2fbfb13957...80069fa9dd00
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.