[wesnoth-commits] [wesnoth/wesnoth] e0b02e: New helper function

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e0b02ea48e2d4a17256e044c59b9e43fea64cc3b
      https://github.com/wesnoth/wesnoth/commit/e0b02ea48e2d4a17256e044c59b9e43fea64cc3b
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  New helper function


  Commit: 55e592b60ef19fdea90963903373f094f805df41
      https://github.com/wesnoth/wesnoth/commit/55e592b60ef19fdea90963903373f094f805df41
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/attack.hpp

  Log Message:
  -----------
  Add a new overload to combat_modifier


  Commit: bf91032d5747edba77c8d7fd98dfd41dc3218b52
      https://github.com/wesnoth/wesnoth/commit/bf91032d5747edba77c8d7fd98dfd41dc3218b52
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/game_display.hpp

  Log Message:
  -----------
  Expose attack_indicator_src_


  Commit: e632be058c1b7638c5b47b0e446012fda6c5ccf2
      https://github.com/wesnoth/wesnoth/commit/e632be058c1b7638c5b47b0e446012fda6c5ccf2
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Show the alignment the selected unit will have at the mouseover hex, not at its current location, to match the time_of_day and tod_stats reports


  Commit: b5c82627d98e90dc11a091ea99cfa722803e5ceb
      https://github.com/wesnoth/wesnoth/commit/b5c82627d98e90dc11a091ea99cfa722803e5ceb
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Have unit_weapons use the alignment at the mouseover hex, for consistency with the alignment and tod reports


  Commit: 631d6b77994c27d4cb8a83da5ff3e1c5c5b1c099
      https://github.com/wesnoth/wesnoth/commit/631d6b77994c27d4cb8a83da5ff3e1c5c5b1c099
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/attack.hpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp

  Log Message:
  -----------
  Simplify under_leadership().

It now takes a unit pointer directly instead of searching for it by
location, even though callers already had the unit pointer.

This also improves the sidebar weapons report. Now, if the mouseover hex
is adjacent both to an allied leader and to an enemy, the sidebar will
reflect the leadership bonus.


  Commit: 6f5ee0ba0d004ce15e03736f579ce4a411718134
      https://github.com/wesnoth/wesnoth/commit/6f5ee0ba0d004ce15e03736f579ce4a411718134
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Rename formal parameter


  Commit: 049541738d2f22dd61c1b766ee3c87c8b7f2fe9d
      https://github.com/wesnoth/wesnoth/commit/049541738d2f22dd61c1b766ee3c87c8b7f2fe9d
  Author: josteph <josteph at fastmail.com>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Simplify under_leadership() further.

Avoid an expensive clone().


Compare: https://github.com/wesnoth/wesnoth/compare/fe23be1f1c4c...049541738d2f
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.