[wesnoth-commits] [wesnoth/wesnoth] 08b7d1: fix #3396 lua_function= doesn't work in [effect][f...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 08b7d1b1ac2e469bab55c37fe73a40f0df603b04
      https://github.com/wesnoth/wesnoth/commit/08b7d1b1ac2e469bab55c37fe73a40f0df603b04
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  fix #3396 lua_function= doesn't work in [effect][filter]

unfortunately this adds an annoying const_cast. The old code 'worked around'
this by getting a nonconst reference to the same unit via the unit map,
which i think is not better just hides the issue.


  Commit: 3591e82586896c8923de1d45cf9c30d25c522a3f
      https://github.com/wesnoth/wesnoth/commit/3591e82586896c8923de1d45cf9c30d25c522a3f
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M data/lua/wml/harm_unit.lua
    M src/actions/attack.cpp
    M src/ai/default/attack.cpp
    M src/ai/simulated_actions.cpp
    M src/attack_prediction.cpp
    M src/game_config.cpp
    M src/game_config.hpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_kernel_base.cpp

  Log Message:
  -----------
  add game_config.combat experience

and make [harm_unit] use these values instead of hardcoded 8*level for
killing and level for combat.


  Commit: 69cdbe8da76e37d4bb827dad97ce99d4ef16cde2
      https://github.com/wesnoth/wesnoth/commit/69cdbe8da76e37d4bb827dad97ce99d4ef16cde2
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-09-10 (Mon, 10 Sep 2018)

  Changed paths:
    M src/scripting/lua_common.cpp

  Log Message:
  -----------
  fix 3541 : crash in lua tstring comparision


Compare: https://github.com/wesnoth/wesnoth/compare/00e41b9857e8...69cdbe8da76e
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.