[wesnoth-commits] [wesnoth/wesnoth] d1391f: Move ms_after= to the right place in music macros ...

[Jyrki Vesterinen]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d1391fee8e169b58f21498042dbccb1a00aff781
      https://github.com/wesnoth/wesnoth/commit/d1391fee8e169b58f21498042dbccb1a00aff781
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2019-10-13 (Sun, 13 Oct 2019)

  Changed paths:
    M data/core/macros/sound-utils.cfg

  Log Message:
  -----------
  Move ms_after= to the right place in music macros (#4459)

I originally added it in #719. At that point ms_after= affected the *previous*
track due to a bug; however, I had assumed the behavior to be intentional and
compensated for it by adding ms_after= to the first track of a scenario instead
of the story screen music.

In April, I saw the documentation for ms_after= which said that it's supposed
to affect the track itself, not the previous one. Hence, I fixed the bug in
commit b023b818c742cee0bc75460235c9d1088c0b495d. However, I had forgotten that the changes I had made
in #719 depended on the old broken behavior of ms_after=.

This commit moves ms_after= to the right place, restoring the fade-out on
scenario start and removing the pointless pause after the first track.