[wesnoth-commits] [wesnoth/wesnoth] d4c34c: Fix the MP Create Dialog's handling of unplayable ...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d4c34c558616f6a58766a00c623ad27c34db314e
      https://github.com/wesnoth/wesnoth/commit/d4c34c558616f6a58766a00c623ad27c34db314e
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2020-03-16 (Mon, 16 Mar 2020)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  Fix the MP Create Dialog's handling of unplayable maps

The UX seems to already be prepared for this - if the map doesn't load then
the create_engine class puts an error message in the map description, which
is shown on the top-left of the MP Create Dialog when the map is selected.

Fixes bugs #3149, #4395 and #4545.  The block deleted in this commit skipped
adding an entry to the games_list listbox, which broke assumptions elsewhere
that the indices returned by create_game_.get_filtered_level_indices()
correspond to the indices in the listbox.


  Commit: c173d01bac0f18dd551ec7cdee07216d2e9a73f8
      https://github.com/wesnoth/wesnoth/commit/c173d01bac0f18dd551ec7cdee07216d2e9a73f8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-03-16 (Mon, 16 Mar 2020)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  Merge pull request #4809 from stevecotton/mp_create_unknown_tile_master

Fix the MP Create Dialog's handling of unplayable maps


Compare: https://github.com/wesnoth/wesnoth/compare/4682b45de1ee...c173d01bac0f