[wesnoth-commits] [wesnoth/wesnoth] 9520d2: Fix the MP Create Dialog's handling of unplayable ...

Charles Dang noreply at github.com
Mon Mar 16 02:12:41 UTC 2020


  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9520d27ab35ab64b13472d86873ecc8376217156
      https://github.com/wesnoth/wesnoth/commit/9520d27ab35ab64b13472d86873ecc8376217156
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2020-03-16 (Mon, 16 Mar 2020)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  Fix the MP Create Dialog's handling of unplayable maps

The UX seems to already be prepared for this - if the map doesn't load then
the create_engine class puts an error message in the map description, which
is shown on the top-left of the MP Create Dialog when the map is selected.

Fixes bugs #3149, #4395 and #4545.  The block deleted in this commit skipped
adding an entry to the games_list listbox, which broke assumptions elsewhere
that the indices returned by create_game_.get_filtered_level_indices()
correspond to the indices in the listbox.


  Commit: 029524028b18460b852c035162d5d2dc62994282
      https://github.com/wesnoth/wesnoth/commit/029524028b18460b852c035162d5d2dc62994282
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-03-16 (Mon, 16 Mar 2020)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  Merge pull request #4810 from stevecotton/mp_create_unknown_tile_1_14

Fix the MP Create Dialog's handling of unplayable maps (1.14 branch)


Compare: https://github.com/wesnoth/wesnoth/compare/c9a313898789...029524028b18



More information about the Commits mailing list