[wesnoth-commits] [wesnoth/wesnoth] ec2298: Convert uses of deprecated GUI2 API

[Celtic Minstrel]

  Branch: refs/heads/lua_reorg
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ec22988b301fdcd7b7c486b59b45766b05115c41
      https://github.com/wesnoth/wesnoth/commit/ec22988b301fdcd7b7c486b59b45766b05115c41
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/utils/zombie_recruit_dialog.lua
    M data/campaigns/tutorial/lua/character_selection.lua
    M data/scenario-test.cfg

  Log Message:
  -----------
  Convert uses of deprecated GUI2 API

This covers everything outside of World Conquest:
- SotA zombie dialog (was mostly converted already, just needed module name update)
- Tutorial character select
- Test scenario sample dialog


  Commit: 08ea74a2ddee6bd587a2eb3483b2920a69dafefc
      https://github.com/wesnoth/wesnoth/commit/08ea74a2ddee6bd587a2eb3483b2920a69dafefc
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/lua/core.lua

  Log Message:
  -----------
  fixup set_music deprecation


  Commit: 683d935242a1a02d862d59b6f150ee973ac9fc9e
      https://github.com/wesnoth/wesnoth/commit/683d935242a1a02d862d59b6f150ee973ac9fc9e
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Fix missing image in the test scenario sample dialog


  Commit: d94b1d151becd218bd2d91738694e4e770cef55a
      https://github.com/wesnoth/wesnoth/commit/d94b1d151becd218bd2d91738694e4e770cef55a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/campaigns/World_Conquest/lua/game_mechanics/invest/invest_show_dialog.lua
    M data/campaigns/World_Conquest/lua/game_mechanics/invest/invest_tellunit.lua
    M data/campaigns/World_Conquest/lua/game_mechanics/pickup_confirmation_dialog.lua
    M data/campaigns/World_Conquest/lua/game_mechanics/wocopedia/help.lua
    M data/campaigns/World_Conquest/lua/map/settings/settings_dialog.lua

  Log Message:
  -----------
  Convert uses of the old GUI2 API in World Conquest


  Commit: d7ddf1427bb202f77726dace8de0ae1441a182f0
      https://github.com/wesnoth/wesnoth/commit/d7ddf1427bb202f77726dace8de0ae1441a182f0
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M src/scripting/lua_kernel_base.cpp

  Log Message:
  -----------
  Remove commented-out old GUI2 API entries


  Commit: 8fe5f311c31827b7990659e6d68cea44b4bc5225
      https://github.com/wesnoth/wesnoth/commit/8fe5f311c31827b7990659e6d68cea44b4bc5225
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Define the sample dialog in the test scenario in WML instead of in Lua

I thought it would be nice to have at least one piece of example code that does this.

It also serves as a test to ensure that this technique actually works.


Compare: https://github.com/wesnoth/wesnoth/compare/81e304b7c7af...8fe5f311c318