[wesnoth-commits] [wesnoth/wesnoth] 4684c5: Apply the deprecation standard to the new GUI2 API

[Celtic Minstrel]

  Branch: refs/heads/lua_reorg
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4684c567a6282dfc45329f07d411b26bff778f26
      https://github.com/wesnoth/wesnoth/commit/4684c567a6282dfc45329f07d411b26bff778f26
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/core/_main.cfg
    R data/lua/backwards-compatibility.lua
    M data/lua/core.lua

  Log Message:
  -----------
  Apply the deprecation standard to the new GUI2 API

This also removes backwards-compatibility.lua altogether.
It's no longer correct in the general case to add backwards compatibility code to this file, so removing it entirely avoids situations where compatibility code is incorrectly added there.


  Commit: 3821374f30764bd671316fc52c2f5612f4379b4c
      https://github.com/wesnoth/wesnoth/commit/3821374f30764bd671316fc52c2f5612f4379b4c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/lua/core.lua

  Log Message:
  -----------
  Don't deprecate wesnoth.fire


  Commit: e57e46e04094b0d16eac5a5990771ae8cbddcc0c
      https://github.com/wesnoth/wesnoth/commit/e57e46e04094b0d16eac5a5990771ae8cbddcc0c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/utils/zombie_recruit_dialog.lua
    M data/campaigns/tutorial/lua/character_selection.lua
    M data/scenario-test.cfg

  Log Message:
  -----------
  Convert uses of deprecated GUI2 API

This covers everything outside of World Conquest:
- SotA zombie dialog (was mostly converted already, just needed module name update)
- Tutorial character select
- Test scenario sample dialog


  Commit: c85b46ca32403827880e034d27a6a16477799521
      https://github.com/wesnoth/wesnoth/commit/c85b46ca32403827880e034d27a6a16477799521
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/lua/core.lua

  Log Message:
  -----------
  fixup set_music deprecation


  Commit: 63408230caf2121625b6ce9361772e7f3507937f
      https://github.com/wesnoth/wesnoth/commit/63408230caf2121625b6ce9361772e7f3507937f
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Fix missing image in the test scenario sample dialog


  Commit: 0e1b968e8dde2a6946a9c35735b2f9bfa9e24f63
      https://github.com/wesnoth/wesnoth/commit/0e1b968e8dde2a6946a9c35735b2f9bfa9e24f63
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/campaigns/World_Conquest/lua/game_mechanics/invest/invest_show_dialog.lua
    M data/campaigns/World_Conquest/lua/game_mechanics/invest/invest_tellunit.lua
    M data/campaigns/World_Conquest/lua/game_mechanics/pickup_confirmation_dialog.lua
    M data/campaigns/World_Conquest/lua/game_mechanics/wocopedia/help.lua
    M data/campaigns/World_Conquest/lua/map/settings/settings_dialog.lua

  Log Message:
  -----------
  Convert uses of the old GUI2 API in World Conquest


  Commit: 8b3b609261c9f536c63844a9e3ee4b05aa840d8e
      https://github.com/wesnoth/wesnoth/commit/8b3b609261c9f536c63844a9e3ee4b05aa840d8e
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M src/scripting/lua_kernel_base.cpp

  Log Message:
  -----------
  Remove commented-out old GUI2 API entries


  Commit: 044a7c9ffcbcdb34f9b6f44cc51b5f3d15c70313
      https://github.com/wesnoth/wesnoth/commit/044a7c9ffcbcdb34f9b6f44cc51b5f3d15c70313
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2020-09-26 (Sat, 26 Sep 2020)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Define the sample dialog in the test scenario in WML instead of in Lua

I thought it would be nice to have at least one piece of example code that does this.

It also serves as a test to ensure that this technique actually works.


Compare: https://github.com/wesnoth/wesnoth/compare/8fe5f311c318...044a7c9ffcbc