[wesnoth-commits] [wesnoth/wesnoth] a5b714: Fix attack prediction assert

[mattsc]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a5b714e5bd205744671b3fa32206226fa7cdca3d
      https://github.com/wesnoth/wesnoth/commit/a5b714e5bd205744671b3fa32206226fa7cdca3d
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2021-03-12 (Fri, 12 Mar 2021)

  Changed paths:
    M src/attack_prediction.cpp

  Log Message:
  -----------
  Fix attack prediction assert

The corrections applied in calculate_probability_of_debuff() are already taken into account in the main attack outcome calculation for being slowed.  They do not need to be applied again, that only needs to be done for being poisoned.  Doing this for being slowed also can cause an assert, such as the one reported in issue #5533 (and probably also the one in issue #5002).

Fixes #5533


  Commit: 649adaefd8b65a9c1a93ae350045aa2bd1f18c4e
      https://github.com/wesnoth/wesnoth/commit/649adaefd8b65a9c1a93ae350045aa2bd1f18c4e
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2021-03-13 (Sat, 13 Mar 2021)

  Changed paths:
    M src/attack_prediction.cpp

  Log Message:
  -----------
  Merge pull request #5606 from mattsc/fix_attack_prediction_assert

Fix attack prediction assert


Compare: https://github.com/wesnoth/wesnoth/compare/1f400d367890...649adaefd8b6