[wesnoth-commits] [wesnoth/wesnoth] 0d5c2b: Fix attack prediction assert

[mattsc]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0d5c2b16585cd4592f8f653aa76491f6f11976ee
      https://github.com/wesnoth/wesnoth/commit/0d5c2b16585cd4592f8f653aa76491f6f11976ee
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2021-03-13 (Sat, 13 Mar 2021)

  Changed paths:
    M src/attack_prediction.cpp

  Log Message:
  -----------
  Fix attack prediction assert

The corrections applied in calculate_probability_of_debuff() are already taken into account in the main attack outcome calculation for being slowed.  They do not need to be applied again, that only needs to be done for being poisoned.  Doing this for being slowed also can cause an assert, such as the one reported in issue #5533 (and probably also the one in issue #5002).

Fixes #5533