[Commits] [wesnoth/wesnoth] 941e1c: Stop replacing listboxes with panes with --new-wid...

GitHub noreply at github.com
Tue Jan 10 15:36:12 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 941e1c2a84319f14dd12596dcdc9bb89c1dda38b
      https://github.com/wesnoth/wesnoth/commit/941e1c2a84319f14dd12596dcdc9bb89c1dda38b
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-01-05 (Thu, 05 Jan 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  Stop replacing listboxes with panes with --new-widgets

I don't see the point of such a change. More important, it breaks all
dialogs which search a listbox with find_widget<listbox>() and don't have
a separate code path for --new-widgets, such as the new add-on manager.
In particular, testing the new add-on manager without code changes was
impossible because it was disabled without --new-widgets and failed to
find the add-on list with it.


  Commit: c2e6de3a95a8e2cc926714c22529f23e925ea4ec
      https://github.com/wesnoth/wesnoth/commit/c2e6de3a95a8e2cc926714c22529f23e925ea4ec
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-01-10 (Tue, 10 Jan 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  Merge pull request #910 from wesnoth/remove-pane-experiment

Stop replacing listboxes with panes with --new-widgets


Compare: https://github.com/wesnoth/wesnoth/compare/ae07bcb3e102...c2e6de3a95a8


More information about the Commits mailing list