[wesnoth-commits] [wesnoth/wesnoth] d7edb8: GUI2: added a bunch of missing virtual specifiers

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d7edb83b165c5e6225783e1bbb65d1d040bebe6d
      https://github.com/wesnoth/wesnoth/commit/d7edb83b165c5e6225783e1bbb65d1d040bebe6d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/button.hpp
    M src/gui/widgets/horizontal_scrollbar.hpp
    M src/gui/widgets/repeating_button.hpp
    M src/gui/widgets/slider.hpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.hpp
    M src/gui/widgets/vertical_scrollbar.hpp

  Log Message:
  -----------
  GUI2: added a bunch of missing virtual specifiers


  Commit: 2d9b7d82c6a602c0b142bea38cebdb3650db62d6
      https://github.com/wesnoth/wesnoth/commit/2d9b7d82c6a602c0b142bea38cebdb3650db62d6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp

  Log Message:
  -----------
  GUI2/[Multi]Menu Button: removed retval handling

Retvals are only relevant for widgets that are supposed to trigger something
like a window closure, and that makes sense for neither of these widgets. The
only reason the Menu Button widget has it is its original implementation was
largely copied from the Button widget, and the Multimenu Button widget copied
from the Menu Button widget.


  Commit: 55f14ff22cf09c8e28da3c97731913349073fcd1
      https://github.com/wesnoth/wesnoth/commit/55f14ff22cf09c8e28da3c97731913349073fcd1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/multimenu_button.hpp

  Log Message:
  -----------
  GUI2/Menu Button: changed callbacks to NOTIFY_MODIFIED ones

menu_button doesn't even actually inherit from clickable_item. The only reason
[dis]connect_click_handler was declared in this class is the original implementation
was copied extensively from the Button widget.

Using NOTIFY_MODIFIED also means callbacks can fire if set_value/set_selected is used
on a menu_button.

The [dis]connect_click_handler functions were also removed from multimenu_button. All
callbacks for this widget type already used NOTIFY_MODIFIED signals.


  Commit: a5169f7c501ed6675ba814cd86f4f10bf9059544
      https://github.com/wesnoth/wesnoth/commit/a5169f7c501ed6675ba814cd86f4f10bf9059544
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M changelog.md
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp

  Log Message:
  -----------
  GUI2/Menu Button: allow changing selections with the scrollwheel (closes #3251)'

The changelog entry is under 1.14.3+dev since this is going to be backported.


  Commit: 0632f91bd6492b8cc6ce34866e6fe76eecc3d8b4
      https://github.com/wesnoth/wesnoth/commit/0632f91bd6492b8cc6ce34866e6fe76eecc3d8b4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/faction_select.hpp
    M src/gui/dialogs/multiplayer/mp_join_game.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp

  Log Message:
  -----------
  Faction Select: declared an execute() helper


  Commit: c2c613325b075a57728e4bf87659fd2606817630
      https://github.com/wesnoth/wesnoth/commit/c2c613325b075a57728e4bf87659fd2606817630
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/faction_select.hpp

  Log Message:
  -----------
  Faction Select: fixed changes persisting even if you cancel the dialog


Compare: https://github.com/wesnoth/wesnoth/compare/ad7bc19dd989...c2c613325b07
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.