[wesnoth-commits] [wesnoth/wesnoth] 711007: GUI2: added a bunch of missing virtual specifiers

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 71100769264e7e303a6bf9cd2a852782d437daf6
      https://github.com/wesnoth/wesnoth/commit/71100769264e7e303a6bf9cd2a852782d437daf6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/button.hpp
    M src/gui/widgets/horizontal_scrollbar.hpp
    M src/gui/widgets/repeating_button.hpp
    M src/gui/widgets/slider.hpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.hpp
    M src/gui/widgets/vertical_scrollbar.hpp

  Log Message:
  -----------
  GUI2: added a bunch of missing virtual specifiers


  Commit: 8a26ab093b011db10a6fa3edb38b18682b1c97e8
      https://github.com/wesnoth/wesnoth/commit/8a26ab093b011db10a6fa3edb38b18682b1c97e8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp

  Log Message:
  -----------
  GUI2/[Multi]Menu Button: removed retval handling

Retvals are only relevant for widgets that are supposed to trigger something
like a window closure, and that makes sense for neither of these widgets. The
only reason the Menu Button widget has it is its original implementation was
largely copied from the Button widget, and the Multimenu Button widget copied
from the Menu Button widget.


  Commit: d5233620e4200e1bb1199c4a36ec7fab9ba76ce2
      https://github.com/wesnoth/wesnoth/commit/d5233620e4200e1bb1199c4a36ec7fab9ba76ce2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/multimenu_button.hpp

  Log Message:
  -----------
  GUI2/Menu Button: changed callbacks to NOTIFY_MODIFIED ones

menu_button doesn't even actually inherit from clickable_item. The only reason
[dis]connect_click_handler was declared in this class is the original implementation
was copied extensively from the Button widget.

Using NOTIFY_MODIFIED also means callbacks can fire if set_value/set_selected is used
on a menu_button.

The [dis]connect_click_handler functions were also removed from multimenu_button. All
callbacks for this widget type already used NOTIFY_MODIFIED signals.


  Commit: 880152e9f0893b1247b5f4fe3acc9f6dc6e7a3d2
      https://github.com/wesnoth/wesnoth/commit/880152e9f0893b1247b5f4fe3acc9f6dc6e7a3d2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M changelog.md
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp

  Log Message:
  -----------
  GUI2/Menu Button: allow changing selections with the scrollwheel (closes #3251)'

The changelog entry is under 1.14.3+dev since this is going to be backported.


  Commit: 8d6d3ec8f361a85432c4d66451761365bee8bc4b
      https://github.com/wesnoth/wesnoth/commit/8d6d3ec8f361a85432c4d66451761365bee8bc4b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/faction_select.hpp
    M src/gui/dialogs/multiplayer/mp_join_game.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp

  Log Message:
  -----------
  Faction Select: declared an execute() helper


  Commit: 12671fa715768b20bd9c5acaafed952cf2e44327
      https://github.com/wesnoth/wesnoth/commit/12671fa715768b20bd9c5acaafed952cf2e44327
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/faction_select.hpp

  Log Message:
  -----------
  Faction Select: fixed changes persisting even if you cancel the dialog


Compare: https://github.com/wesnoth/wesnoth/compare/36bf101be084...12671fa71576
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.