[wesnoth-commits] [wesnoth/wesnoth] fb490d: gui2/unit_create: Fix segfault on empty list when ...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: fb490dd97147c7989a8932a37889700f0e1a8ff7
      https://github.com/wesnoth/wesnoth/commit/fb490dd97147c7989a8932a37889700f0e1a8ff7
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-09-01 (Sat, 01 Sep 2018)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/unit_create.cpp

  Log Message:
  -----------
  gui2/unit_create: Fix segfault on empty list when updating unit preview

This happens when the list comes up empty because of a non-matching
filter, e.g. "Elvish Archer222" and the user clicks on one of the gender
options in this state.

Ideally we should clear the preview pane and disable the options and OK
button here, but the former appears impossible and for some reason
changing the pane's visibility in filter_text_changed() doesn't work
reliably.


  Commit: b4e7b5b9af14bf05715235476374b42742b2d68c
      https://github.com/wesnoth/wesnoth/commit/b4e7b5b9af14bf05715235476374b42742b2d68c
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-09-01 (Sat, 01 Sep 2018)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/unit_create.cpp

  Log Message:
  -----------
  gui2/unit_create: Allow searching by race name as well


Compare: https://github.com/wesnoth/wesnoth/compare/160389cd725f...b4e7b5b9af14
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.